[
https://issues.apache.org/jira/browse/LUCENE-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925932#comment-13925932
]
Robert Muir commented on LUCENE-5487:
-------------------------------------
In this case no problem, but just as an FYI, if you have trunk/ and branch/,
you always want to run the differ outside of both (this way the patch prefixes
are the same: this one cant be applied by any patch tool).
But this is no problem for me to review, i can just switch to your branch to
see the context!
> Can we separate "top scorer" from "sub scorer"?
> -----------------------------------------------
>
> Key: LUCENE-5487
> URL: https://issues.apache.org/jira/browse/LUCENE-5487
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 4.8, 5.0
>
> Attachments: LUCENE-5487.patch, LUCENE-5487.patch, LUCENE-5487.patch
>
>
> This is just an exploratory patch ... still many nocommits, but I
> think it may be promising.
> I find the two booleans we pass to Weight.scorer confusing, because
> they really only apply to whoever will call score(Collector) (just
> IndexSearcher and BooleanScorer).
> The params are pointless for the vast majority of scorers, because
> very, very few query scorers really need to change how top-scoring is
> done, and those scorers can *only* score top-level (throw throw UOE
> from nextDoc/advance). It seems like these two types of scorers
> should be separately typed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
