[ 
https://issues.apache.org/jira/browse/SOLR-5183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hoss Man updated SOLR-5183:
---------------------------

    Attachment: SOLR-5183.patch

Varun: your patch looks pretty good to me,

I beefed up the test a bit to convince myself that it would correctly handle:
* grand child docs
* {{_childDocument_}} and regular fields in various orders
* duplicate {{_childDocument_}} keys

...and in the process discovered what appears to be a pre-existing bug 
regarding field value ordering when the fieldName key is duplicated in the 
JSON.  It looks like it should be fairly trivial to fix, so i'm going to open a 
new issue for that and get it fixed & backported to 4x, and then i'll come back 
and revist this patch

> Add block support for JSONLoader
> --------------------------------
>
>                 Key: SOLR-5183
>                 URL: https://issues.apache.org/jira/browse/SOLR-5183
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Varun Thacker
>             Fix For: 4.7
>
>         Attachments: SOLR-5183.patch, SOLR-5183.patch, SOLR-5183.patch, 
> SOLR-5183.patch
>
>
> We should be able to index block documents in JSON format



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to