[
https://issues.apache.org/jira/browse/SOLR-5775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912884#comment-13912884
]
Simon Willnauer commented on SOLR-5775:
---------------------------------------
I wrote a mail about this during building the RC for 4.7 and I share roberts
concerns. I know that is hard to get distributed tests to pass but it should be
our main objective to get things stable. I think it's mandatory for getting new
contributors in as well as for existing contributors to develop code. For me as
a RM it was a nightmare really to realize that a release build skips all the
solr tests because if we would run them it would mean the RC would never happen
at least on my machine that was the case when I enabled them. It's super
important to have a build that passes otherwise you never know if you broke
something. If we have a test that sometimes fails then try to fix it or try to
catch the condition under that it is failing and let it pass so that we can see
if there is a difference in the failure.
bq. ..but our 'steady state' needs to be BUILD SUCCESSFUL.
I could not agree more
> Disable constantly failing solr tests
> -------------------------------------
>
> Key: SOLR-5775
> URL: https://issues.apache.org/jira/browse/SOLR-5775
> Project: Solr
> Issue Type: Bug
> Components: Build
> Reporter: Robert Muir
>
> Currently, solr tests are failing 90%+ of the time. We've been through this
> before many times, the argument is always that someone is looking at the
> failures and knows which ones are bad.
> This argument is a lie. Nobody is watching these failures, or
> DistributedQueryComponentOptimizationTest would not have failed repeatedly
> for two straight days when the fix was trivial (I fixed this last night:
> http://svn.apache.org/r1571930)
> Its frustrating to me as a committer, solr tests *NEVER* pass on my machine,
> no matter how many times I try. How can i possibly commit something without
> knowing i am making the situation even worse?
> This is all a big problem for developers, release managers, even users of the
> project. The test suite should pass.
> The old argument that "solr tests are allowed to fail" is no longer valid. I
> will disable all constantly failing tests.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
