[
https://issues.apache.org/jira/browse/SOLR-4470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910431#comment-13910431
]
Per Steffensen commented on SOLR-4470:
--------------------------------------
bq. No whitespace-only diffs
Good
bq. Javadoc for AuthCredentials class
Nice
bq. CoreAdminRequest#persist() was undeprecated by previous patch, assuming
that was a typo, re-adding deprecation.
Not by intent from my side, so the re-adding seem correct
bq. In HttpClientUtil#createClient(...) the code in prev patch was ...
Boolean.getBoolean was the intention. And the result will not always be false -
not if you set the JVM-param to "true". This is done in SecurityDistributedTest
so that we can oversteer credentials used in inter-solr-node requests from the
test. Please revert to Boolean.getBoolean.
Ad) CHANGES.txt
{code}
... The feature propagates credentials from outer request to the sub-requests
...
{code}
I can live with this one, but maybe it should be expressed differently. The
thing you describe is only true if you use
UseSuperRequestAuthCredentialsSubRequestFactory - you can make other
implementations of SubRequestFactory where it is not true. And it is only true
for "internal requests that is a direct reaction to a request from the
outside". In case of "internal requests that is not triggered by a request from
the outside" it can never be true - there are no outer request to propagate
credentials from. For such requests, if you use
SystemPropertiesAuthCredentialsInternalRequestFactory, you can control basic
http credentials through JVM-params, but here you can implement your own
solution as well. Just wanted to make it clear. If you want to keep what you
wrote, then ok for me.
> Support for basic http auth in internal solr requests
> -----------------------------------------------------
>
> Key: SOLR-4470
> URL: https://issues.apache.org/jira/browse/SOLR-4470
> Project: Solr
> Issue Type: New Feature
> Components: clients - java, multicore, replication (java), SolrCloud
> Affects Versions: 4.0
> Reporter: Per Steffensen
> Assignee: Jan Høydahl
> Labels: authentication, https, solrclient, solrcloud, ssl
> Fix For: 5.0
>
> Attachments: SOLR-4470.patch, SOLR-4470.patch, SOLR-4470.patch,
> SOLR-4470.patch, SOLR-4470.patch, SOLR-4470.patch,
> SOLR-4470_branch_4x_r1452629.patch, SOLR-4470_branch_4x_r1452629.patch,
> SOLR-4470_branch_4x_r1454444.patch, SOLR-4470_trunk_r1568857.patch
>
>
> We want to protect any HTTP-resource (url). We want to require credentials no
> matter what kind of HTTP-request you make to a Solr-node.
> It can faily easy be acheived as described on
> http://wiki.apache.org/solr/SolrSecurity. This problem is that Solr-nodes
> also make "internal" request to other Solr-nodes, and for it to work
> credentials need to be provided here also.
> Ideally we would like to "forward" credentials from a particular request to
> all the "internal" sub-requests it triggers. E.g. for search and update
> request.
> But there are also "internal" requests
> * that only indirectly/asynchronously triggered from "outside" requests (e.g.
> shard creation/deletion/etc based on calls to the "Collection API")
> * that do not in any way have relation to an "outside" "super"-request (e.g.
> replica synching stuff)
> We would like to aim at a solution where "original" credentials are
> "forwarded" when a request directly/synchronously trigger a subrequest, and
> fallback to a configured "internal credentials" for the
> asynchronous/non-rooted requests.
> In our solution we would aim at only supporting basic http auth, but we would
> like to make a "framework" around it, so that not to much refactoring is
> needed if you later want to make support for other kinds of auth (e.g. digest)
> We will work at a solution but create this JIRA issue early in order to get
> input/comments from the community as early as possible.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
