Simon, I'll fix the typo in CHANGES.txt and also move the issue under optimisations as Robert suggested.
On 21 February 2014 14:24, Uwe Schindler <[email protected]> wrote: > SUCCESS! [2:00:24.392734] > > One thing we should fix in the future: The MANIFEST.MF of almost all JAR > files contains the following line: > > Main-Class: ${main.class} > > This happens because the ANT property "main.class" is undefined for most > modules. Maybe this was added for one of the modules (I assume that the > Solr-Morphline JARs use this attribute?). We should add some if/then/else > structure to the <jarify/> task that only sets this property, if it is > actually defined. Otherwise remove it (I think ANT does this automatically > if its empty, means string-empty, have to try out) > > This leads to an error if the file is double-clicked or started via "java > -jar": > > C:\Users\Uwe Schindler\Desktop>java -jar lucene-core-4.7.0.jar > Fehler: Hauptklasse ${main.class} konnte nicht gefunden oder geladen werden > > Uwe > > This is not terrible so it should hold the release, but if we respin, we > should fix it. I will open an issue. > > Nevertheless, +1 to release! > > Uwe > > ----- > Uwe Schindler > H.-H.-Meier-Allee 63, D-28213 Bremen > http://www.thetaphi.de > eMail: [email protected] > > > > -----Original Message----- > > From: Simon Willnauer [mailto:[email protected]] > > Sent: Thursday, February 20, 2014 9:52 PM > > To: [email protected] > > Subject: [VOTE] Lucene / Solr 4.7.0 RC3 > > > > Please vote for the third Release Candidate for Lucene/Solr 4.7.0 > > > > you can download it here: > > http://people.apache.org/~simonw/staging_area/lucene-solr-4.7.0-RC3- > > rev1570248/ > > > > or run the smoke tester directly with this commandline (don't forget to > set > > JAVA6_HOME etc.): > > > > $ python3.2 -u dev-tools/scripts/smokeTestRelease.py > > http://people.apache.org/~simonw/staging_area/lucene-solr-4.7.0-RC3- > > rev1570248/ > > 1570248 4.7.0 /tmp/smoke_test_4_7 > > > > Smoketester said: SUCCESS! > > > > here is my +1 > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] For additional > > commands, e-mail: [email protected] > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Met vriendelijke groet, Martijn van Groningen
