[
https://issues.apache.org/jira/browse/LUCENE-5437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13897083#comment-13897083
]
Simon Willnauer commented on LUCENE-5437:
-----------------------------------------
I like this patch much better. I wonder if we can come up with a better naming
for the variables / options. In _PatternCaptureGroupTokenFilter_ we use
_preserveOriginal_ which I kind of like better. For the tests I wonder if you
can make _assertNextTerms_ accept a _ASCIIFoldingFilter_ instead of a
_TokenFilter_ and add a getter to it so we can randomly set if the orig should
be preserved? That would also prevent the subclass?
> ASCIIFoldingFilter that emits both unfolded and folded tokens
> -------------------------------------------------------------
>
> Key: LUCENE-5437
> URL: https://issues.apache.org/jira/browse/LUCENE-5437
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Nik Everett
> Assignee: Simon Willnauer
> Priority: Minor
> Attachments: LUCENE-5437.patch
>
>
> I've found myself wanting an ASCIIFoldingFilter that emits both the folded
> tokens and the original, unfolded tokens.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
