[
https://issues.apache.org/jira/browse/LUCENE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866227#comment-13866227
]
Benson Margulies edited comment on LUCENE-5388 at 1/9/14 2:41 AM:
------------------------------------------------------------------
I have Solr test failures in PreAnalyzedField, which has some stubborn fondness
for the idea of a reader passed to a constructor. But that seems to be all
that's broken; a few Solr failures (based on 'ant test').
was (Author: bmargulies):
I have Solr test failures in PreAnalyzedField, which has some stubborn fondness
for the idea of a reader passed to a constructor.
> Eliminate construction over readers for Tokenizer
> -------------------------------------------------
>
> Key: LUCENE-5388
> URL: https://issues.apache.org/jira/browse/LUCENE-5388
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/other
> Reporter: Benson Margulies
>
> In the modern world, Tokenizers are intended to be reusable, with input
> supplied via #setReader. The constructors that take Reader are a vestige.
> Worse yet, they invite people to make mistakes in handling the reader that
> tangle them up with the state machine in Tokenizer. The sensible thing is to
> eliminate these ctors, and force setReader usage.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
