[
https://issues.apache.org/jira/browse/LUCENE-2639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907995#action_12907995
]
Michael McCandless commented on LUCENE-2639:
--------------------------------------------
Awesome! Patch looks good -- all tests pass for me on beast (linux).
It's nice not having to pass random to newXXX.
> remove random juggling in tests, add -Dtests.seed
> -------------------------------------------------
>
> Key: LUCENE-2639
> URL: https://issues.apache.org/jira/browse/LUCENE-2639
> Project: Lucene - Java
> Issue Type: Test
> Components: Tests
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2639.patch
>
>
> Since we added newIndexWriterConfig/newDirectory, etc, a lot of tests are
> juggling randoms around.
> Instead this patch:
> * changes it so LuceneTestCase[J4] manage the random.
> * allow you to set -Dtests.seed=23432432432 to reproduce a test, rather than
> editing the code
> * removes random arguments from newIndexWriterConfig, newDirectory.
> I want to do this before looking at doing things like newField so we can vary
> term vectors, etc.
> I also fixed the solr contrib builds so they arent hiding the exceptions i
> noted in SOLR-2002.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
