[
https://issues.apache.org/jira/browse/SOLR-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Koji Sekiguchi updated SOLR-2046:
---------------------------------
Attachment: SOLR-2046.patch
> add a function to set curl_url in scripts-util
> ----------------------------------------------
>
> Key: SOLR-2046
> URL: https://issues.apache.org/jira/browse/SOLR-2046
> Project: Solr
> Issue Type: Improvement
> Components: replication (scripts)
> Affects Versions: 1.4.1
> Reporter: Koji Sekiguchi
> Priority: Trivial
> Attachments: SOLR-2046.patch, SOLR-2046.patch, SOLR-2046.patch,
> SOLR-2046.patch
>
>
> abc/abo/commit/optimize/readercycle scripts have the following identical
> snippet to set curl_url:
> {code}
> if [[ -n ${solr_url} ]]
> then
> curl_url=${solr_url}
> else
> if [[ -z ${solr_port} ]]
> then
> echo "Solr port number missing in $confFile or command line."
> echo "$USAGE"
> exit 1
> fi
> # use default hostname if not specified
> if [[ -z ${solr_hostname} ]]
> then
> solr_hostname=localhost
> fi
> # use default webapp name if not specified
> if [[ -z ${webapp_name} ]]
> then
> webapp_name=solr
> fi
> curl_url=http://${solr_hostname}:${solr_port}/${webapp_name}/update
> fi
> {code}
> I think it should be moved to scripts-util in order to improve
> readability/maintainability.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]