On Sat, Jul 24, 2010 at 11:30 AM, Uwe Schindler <[email protected]> wrote: > Hi Yonik, > > i would prefer to pass the default QP version constant tot he ctor and simply > switch on the auto-phrase building per default: > > super(schema.getSolrConfig().getLuceneVersion("luceneMatchVersion", > Version.LUCENE_24), defaultField == null ? schema.getDefaultSearchFieldName() > : defaultField, schema.getQueryAnalyzer()); > setAutoGeneratePhraseQueries(true); > > This is cleaner, as there may (an I think there are other things changed > dependent on version?)
Yeah, we could change it to do that... I just used the Version.LUCENE_24 since that's what it was set to before LUCENE-2458 was committed. It won't currently make a functional difference (Solr always explicitly enabled position increments anyway), but I agree your way is cleaner. -Yonik http://www.lucidimagination.com --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
