[ 
https://issues.apache.org/jira/browse/SOLR-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879819#action_12879819
 ] 

Erik Hatcher commented on SOLR-1957:
------------------------------------

These commands should be run, then the patch file attached applied:

{{
svn mv 
contrib/velocity/src/main/java/org/apache/solr/response/VelocityResponseWriter.java
 src/java/org/apache/solr/response/
svn mv contrib/velocity/src/main/java/org/apache/solr/response/PageTool.java 
src/java/org/apache/solr/response/
svn mv 
contrib/velocity/src/main/java/org/apache/solr/response/SolrParamResourceLoader.java
 src/java/org/apache/solr/response/
svn mv 
contrib/velocity/src/main/java/org/apache/solr/response/SolrVelocityResourceLoader.java
 src/java/org/apache/solr/response/
svn mv contrib/velocity/src/test/org/apache/solr/velocity 
src/test/org/apache/solr/
svn mv contrib/velocity/src/main/solr/lib/commons-beanutils-1.7.0.jar lib/
svn mv contrib/velocity/src/main/solr/lib/commons-collections-3.2.1.jar lib/
svn mv contrib/velocity/src/main/solr/lib/commons-lang-2.4.jar lib/
svn mv contrib/velocity/src/main/solr/lib/velocity-1.6.1.jar lib/
svn mv contrib/velocity/src/main/solr/lib/velocity-tools-2.0-beta3.jar lib/
mkdir src/test/test-files/solr/conf/velocity
svn add src/test/test-files/solr/conf/velocity
svn mv contrib/velocity/src/main/solr/conf/velocity/VM_global_library.vm 
src/test/test-files/solr/conf/velocity/
}}

If there is a better way to "patch" all this, let me know. 

> Move VelocityResponseWriter from contrib/ to core
> -------------------------------------------------
>
>                 Key: SOLR-1957
>                 URL: https://issues.apache.org/jira/browse/SOLR-1957
>             Project: Solr
>          Issue Type: Task
>          Components: Response Writers
>    Affects Versions: 1.4
>            Reporter: Erik Hatcher
>            Assignee: Erik Hatcher
>            Priority: Minor
>         Attachments: SOLR-1957.patch
>
>
> The VelocityResponseWriter deserves to be a first-class citizen in Solr, and 
> not tacked on.  The benefit is that UI can be generated right from Solr 
> cleanly and easily via simple templating.  The longer term goal is to migrate 
> from the Solr admin interface from inflexible built-in JSPs to a cleaner 
> layout Velocity set of templates that can be overridden externally if desired 
> (for styling, or adding in plugin UI).
> Another large benefit to having VrW in core is that plugins can then ship 
> with Velocity templates in their own .jar files to provide their own bits of 
> UI or templated response capabilities (text fragments or full HTML responses).
> The impact of this change is a slightly larger solr.war with the additional 
> Velocity dependencies added-in.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to