I'm not sure I understand what you mean - Scorer is a DISI itself, and the scoring formula is mostly controlled by Similarity.
What will be the benefits of the proposed change? Shai On Tue, Jun 8, 2010 at 8:25 AM, John Wang <[email protected]> wrote: > Hi guys: > > I'd like to make a proposal to change the Scorer class/api to the > following: > > > public abstract class Scorer{ > DocIdSetIterator getDocIDSetIterator(); > float score(int docid); > } > > Reasons: > > 1) To build a Scorer from an existing Scorer (e.g. that produces raw scores > from tfidf), one would decorate it, and it would introduce overhead (in > function calls) around nextDoc and advance, even if you just want to augment > the score method which is called much fewer times. > > 2) The current contract forces scoring on the currentDoc in the underlying > iterator. So once you pass "current", you can no longer score. In one of our > use-cases, it is very inconvenient. > > What do you think? I can go ahead and open an issue and work on a patch if > I get some agreement. > > Thanks > > -John >
