[ 
https://issues.apache.org/jira/browse/SOLR-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875723#action_12875723
 ] 

Noble Paul commented on SOLR-1870:
----------------------------------

bq.I'm confused - it seems like you are in favor of my patch, but you also say 
we do not need to support Iterable ...

Oh I misread our patch and  thought you removed support for Iterable . 

In the encoded form there is only iterator/arr. So client does not send any 
unsupported type.  for instance Set is an unsupported type in the encoded form 
but is supported by the library (It is lossy encoding) 

anyway your patch should is fine. 

> Binary Update Request (javabin) fails when the field type of a multivalued 
> SolrInputDocument field is a Set (or any type that is identified as an 
> instance of iterable) 
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-1870
>                 URL: https://issues.apache.org/jira/browse/SOLR-1870
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java, update
>    Affects Versions: 1.4
>            Reporter: Prasanna Ranganathan
>             Fix For: 1.4.1, 3.1, 4.0
>
>         Attachments: SOLR-1870-test.patch, SOLR-1870-test.patch, 
> SOLR-1870.patch, SOLR-1870.patch, SOLR-1870.patch
>
>
> When the field type of a field in a SolrInputDocument is a Collection based 
> on the Set interface, the JavaBinUpdate request fails. It works when sending 
> the document data over XML.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to