It really should turn into a TODO before committing ;) Mike
On Fri, May 21, 2010 at 5:27 PM, Uwe Schindler <[email protected]> wrote: > Hi Shai, > > > > as I said today on Eurocon: I will fix this, when I have the AttributeSource > introspection API finished > (https://issues.apache.org/jira/browse/LUCENE-2374). > > > > Uwe > > > > ----- > > Uwe Schindler > > H.-H.-Meier-Allee 63, D-28213 Bremen > > http://www.thetaphi.de > > eMail: [email protected] > > > > From: Shai Erera [mailto:[email protected]] > Sent: Friday, May 21, 2010 8:58 PM > To: [email protected] > Subject: CharTermAttributeImp contains a nocommit task > > > > Hi > > I don't know if it's on purpose or not, but I've noticed > CharTermAttributeImp contains a nocommit task: > > // nocommit: CharSequence requires that only the contents are returned, > but this is orginal code: "term=" + new String(termBuffer, 0, termLength) > > Not sure if that's supposed to remain there or not ... I suggest it's > removed, or the task removed, if that's not intentional 'cause it looks > fishy. > > Shai --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
