[ 
https://issues.apache.org/jira/browse/SOLR-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860366#action_12860366
 ] 

Hoss Man commented on SOLR-1531:
--------------------------------

Paolo: thanks for working on this.

i gave your patch a quick glance for the most part it seems good -- although we 
should preserve the one arg version of CoreContainer.remove for back compat.

as far as tests go: i can't remember off the top of my head how some of hte 
other CoreContainer tests work -- the existing ones may all be Jetty based 
(using CoreAdminHandler).

We should probably overhaul the SolrTestHarness to be more "multi-core" 
friendly, but one thing you could probably do for now, is let the TestHarness 
create a core, then use getCore().getCoreDescriptor().getCoreContainer().  from 
there you can create/destroy cores to your hearts content (and verify that the 
data dir goes away when it's suppose to, and stays arround when it's suppose to)

> Provide an option to remove the data directory on core unload
> -------------------------------------------------------------
>
>                 Key: SOLR-1531
>                 URL: https://issues.apache.org/jira/browse/SOLR-1531
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Shalin Shekhar Mangar
>             Fix For: 1.5
>
>         Attachments: SOLR-1531.patch
>
>
> Currently the unload command keeps the core's data on disk even though the 
> details of the core is deleted from configuration. Solr should have an option 
> of cleaning the data directory on unload of a core.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to