While master builds are successful, release-2.x builds have been broken on Travis CI for quite a long time (more than 2 months?) that I have the impression that something else is going on there. This becomes a problem for approving PRs like the one in the attachment. Would anybody mind sharing what is going on and how we can fix it, please?
On Fri, May 29, 2020 at 11:13 AM Oleksii Khomchenko < notificati...@github.com> wrote: > Description > > Log4jJsonObjectMapper has JsonInclude.Include.NON_EMPTY enabled > <https://github.com/apache/logging-log4j2/blob/log4j-2.13.3/log4j-core/src/main/java/org/apache/logging/log4j/core/jackson/Log4jJsonObjectMapper.java> > but it is not working at the moment - keys with empty values are still > present in output. It is caused by bug in jackson-databind > <https://github.com/FasterXML/jackson-databind/pull/2615> which I have > fixed. Fix was released as part of jackson-databind:2.11.x. > Why LOG4J2-2749? > > I feel this fix will address user request. > Issue itself log4j2.xml > > <?xml version="1.0" encoding="UTF-8"?> > <Configuration status="WARN"> > <Appenders> > <Console name="Console" target="SYSTEM_OUT"> > <JsonLayout compact="true" properties="true"> > <KeyValuePair key="empty" value="${ctx:empty:-}"/> > </JsonLayout> > </Console> > </Appenders> > <Loggers> > <Root level="DEBUG"> > <AppenderRef ref="Console"/> > </Root> > </Loggers> > </Configuration> > > Main.java > > import org.apache.logging.log4j.LogManager; > import org.apache.logging.log4j.Logger; > > public class Main { > private static final Logger logger = LogManager.getLogger(); > > public static void main(String[] args) { > logger.info("info"); > } > } > > Output > > {"instant":{"epochSecond":1590743485,"nanoOfSecond":93000000},"thread":"main","level":"INFO","loggerName":"org.apache.logging.log4j.core.Main","message":"info","endOfBatch":false,"loggerFqcn":"org.apache.logging.log4j.spi.AbstractLogger","contextMap":{},"threadId":1,"threadPriority":5,"empty":""} > > Notes > > - I have chosen release-2.x while I have actually developed a patch on > 2.13.3 tag. I can rebase to any other brach, just let me know which one > > ------------------------------ > You can view, comment on, or merge this pull request online at: > > https://github.com/apache/logging-log4j2/pull/362 > Commit Summary > > - LOG4J2-2749 - fix JSON Layout output containing empty values while > configured otherwise > > File Changes > > - *M* > > log4j-core/src/test/java/org/apache/logging/log4j/core/layout/JsonLayoutTest.java > > <https://github.com/apache/logging-log4j2/pull/362/files#diff-efc5dc02e2ad193166f66373ddb9e732> > (13) > - *M* pom.xml > > <https://github.com/apache/logging-log4j2/pull/362/files#diff-600376dffeb79835ede4a0b285078036> > (2) > > Patch Links: > > - https://github.com/apache/logging-log4j2/pull/362.patch > - https://github.com/apache/logging-log4j2/pull/362.diff > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/logging-log4j2/pull/362>, or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAARTSIGY2SCXBYER7QV733RT54C5ANCNFSM4NN3X6YA> > . >
