[
https://issues.apache.org/jira/browse/LOG4J2-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129047#comment-16129047
]
ASF GitHub Bot commented on LOG4J2-2013:
----------------------------------------
Github user taylorp36 commented on the issue:
https://github.com/apache/logging-log4j2/pull/108
Yeap, the trouble I had extending TcpSocketManager was that Reconnector and
Socket were both being mutated in the write() and reconnect(). Without having
setters on those fields in TcpSocketManager, duplicating those 2 methods seemed
necessary. I could have still extended TcpSocketManger, but it added
unnecessary complexity just to re-use a few other small methods. The complexity
being that I would have been passing arguments to the TcpSocketManger
constructor that would never be used. Open to any suggestions, maybe there is a
solution here I'm not seeing.
> SslSocketManager does not apply SSLContext on TCP reconnect
> -----------------------------------------------------------
>
> Key: LOG4J2-2013
> URL: https://issues.apache.org/jira/browse/LOG4J2-2013
> Project: Log4j 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.8.2
> Reporter: Taylor Patton
> Assignee: Gary Gregory
> Fix For: 2.9
>
>
> The SslSocketManger is not applying the SSLContext correctly when the TCP
> connection is restarted. Currently the SslSocketManager inherits a
> Reconnector class from TcpSocketManger, which only restarts the TCP
> connection and does not apply SSL correctly.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)