OK, I will move them to core.tools. On Wed, Aug 16, 2017 at 4:32 AM, Matt Sicker <[email protected]> wrote:
> I kind of consider the tools package for command line tools, so it sorta > does make sense to include the command line parser in the same package. > > On 14 August 2017 at 17:36, Remko Popma <[email protected]> wrote: > > > Thank you for retracting your -1, Gary. > > > > All, > > Would core.tools be a better place for this package, just core, or is > > core.util okay? > > > > On Tue, Aug 15, 2017 at 3:03 AM, Gary Gregory <[email protected]> > > wrote: > > > > > Can we please avoid "util" packages, that just tells me "I can't be > > > bothered to think of a good name". Just remove the "util" level IMO. > > > > > > Gary > > > > > > On Mon, Aug 14, 2017 at 12:02 PM, Gary Gregory <[email protected] > > > > > wrote: > > > > > > > Ugh, not a fan, but I'll retract my -1. > > > > > > > > "a single class", yes, but a 4000 line class. > > > > > > > > Gary > > > > > > > > On Mon, Aug 14, 2017 at 11:06 AM, Matt Sicker <[email protected]> > > wrote: > > > > > > > >> Embedding a single class? I don't see the problem with that. We do > it > > > with > > > >> several Commons classes. > > > >> > > > >> On 14 August 2017 at 11:59, Gary Gregory <[email protected]> > > > wrote: > > > >> > > > >> > Wait a minute? We are embedding a third party jar? Yuk! -1, sorry > > that > > > >> is > > > >> > not what I thought was happening. > > > >> > > > > >> > Gary > > > >> > > > > >> > On Aug 14, 2017 10:18, <[email protected]> wrote: > > > >> > > > > >> > > http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ > > > >> > > c2818bec/log4j-core/src/main/java/org/apache/logging/log4j/ > > > >> > > core/util/picocli/CommandLine.java > > > >> > > ------------------------------------------------------------ > > > >> ---------- > > > >> > > diff --git a/log4j-core/src/main/java/ > > > org/apache/logging/log4j/core/ > > > >> > util/picocli/CommandLine.java > > > >> > > b/log4j-core/src/main/java/org/apache/logging/log4j/core/ > > > >> > > util/picocli/CommandLine.java > > > >> > > new file mode 100644 > > > >> > > index 0000000..5c4e9cc >
