sjgllgh commented on code in PR #5201:
URL: https://github.com/apache/linkis/pull/5201#discussion_r1841658962
##########
linkis-engineconn-plugins/spark/src/main/scala/org/apache/linkis/engineplugin/spark/factory/SparkEngineConnFactory.scala:
##########
@@ -137,6 +137,17 @@ class SparkEngineConnFactory extends
MultiExecutorEngineConnFactory with Logging
sparkConfig.setQueue(LINKIS_QUEUE_NAME.getValue(options))
sparkConfig.setPyFiles(SPARK_PYTHON_FILES.getValue(options))
+ val conf = new util.HashMap[String, String]()
+ addSparkConf(conf, SPARK_DRIVER_HOST.key,
SPARK_DRIVER_HOST.getValue(options))
+ addSparkConf(conf, SPARK_DRIVER_PORT.key,
SPARK_DRIVER_PORT.getValue(options))
+ addSparkConf(conf, SPARK_DRIVER_BIND_ADDRESS.key,
SPARK_DRIVER_BIND_ADDRESS.getValue(options))
+ addSparkConf(
+ conf,
+ SPARK_DRIVER_BLOCK_MANAGER_PORT.key,
+ SPARK_DRIVER_BLOCK_MANAGER_PORT.getValue(options)
+ )
+ sparkConfig.setConf(conf)
Review Comment:
This line is necessary because the sparkConf object does not have a directly
available method to set parameters such as spark.driver.port. Instead, these
parameters need to be assigned values through sparkConf.setConf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@linkis.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@linkis.apache.org
For additional commands, e-mail: dev-h...@linkis.apache.org
