[ 
https://issues.apache.org/jira/browse/KNOX-3278?focusedWorklogId=1015750&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1015750
 ]

ASF GitHub Bot logged work on KNOX-3278:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Apr/26 16:21
            Start Date: 15/Apr/26 16:21
    Worklog Time Spent: 10m 
      Work Description: bonampak commented on code in PR #1181:
URL: https://github.com/apache/knox/pull/1181#discussion_r3087882648


##########
gateway-shell-release/pom.xml:
##########
@@ -54,6 +61,7 @@
                                     <excludes>
                                         <exclude>schema/**</exclude>
                                         <exclude>**/*.ldif</exclude>
+                                        
<exclude>META-INF/org/apache/logging/log4j/core/config/plugins/Log4j2Plugins.dat</exclude>

Review Comment:
   if we use maven-shade-plugin:3.4.1 and 
org.apache.logging.log4j:log4j-transform-maven-shade-plugin-extensions, this 
can be fixed by adding 
   `<transformer 
implementation="org.apache.logging.log4j.maven.plugins.shade.transformer.Log4j2PluginCacheFileTransformer"/>`
   Otherwise the Log4j2Plugins.dat will be overwritten by our plugins and will 
not contain the ones shipped by log4j2.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 1015750)
    Time Spent: 0.5h  (was: 20m)

> Update jline to 3.30.6
> ----------------------
>
>                 Key: KNOX-3278
>                 URL: https://issues.apache.org/jira/browse/KNOX-3278
>             Project: Apache Knox
>          Issue Type: Task
>          Components: KnoxShell
>    Affects Versions: 3.0.0
>            Reporter: Tamás Marcinkovics
>            Assignee: Tamás Marcinkovics
>            Priority: Minor
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Update jline.version to 3.30.6.
>  
> Groovy also needs to be updated to version 5, as groovysh 4 still uses jline2.
> [https://groovy-lang.org/changelogs/changelog-5.0.0.html]
> GROOVY-8162: Update Groovysh to JLine3
> https://issues.apache.org/jira/browse/GROOVY-8162)
> AspectJ for JDK17 needs to be upgraded to 1.9.21.1+: 
> [https://github.com/eclipse-aspectj/aspectj/blob/master/docs/release/README-1.9.22.adoc]
> JNA needs to be updated.
> [https://mvnrepository.com/artifact/org.apache.groovy/groovy-groovysh/5.0.4/dependencies]
> net.java.dev.jna:jna:5.18.1
> org.apache.groovy:groovy:5.0.4
> org.jline:jansi:3.30.6
>  
>  
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to