This looks like a useful feature, the strategy makes sense, and the KIP is thorough and nicely written. Thanks!
Cyrus On Thu, Aug 1, 2019, 12:40 PM Chris Egerton <chr...@confluent.io> wrote: > Thanks Arjun! Looks good to me. > > On Thu, Aug 1, 2019 at 12:33 PM Arjun Satish <arjun.sat...@gmail.com> > wrote: > > > Thanks for the feedback, Chris! > > > > Yes, the example is pretty much how Connect will use the new feature. > > Tweaked the section to make this more clear. > > > > Best, > > > > On Fri, Jul 26, 2019 at 11:52 AM Chris Egerton <chr...@confluent.io> > > wrote: > > > > > Hi Arjun, > > > > > > This looks great. The changes to public interface are pretty small and > > > moving the Log4jController class into the clients package seems like > the > > > right way to go. One question I have--it looks like the purpose of this > > KIP > > > is to enable dynamic setting of log levels in the Connect framework, > but > > > it's not clear how the Connect framework will use that new utility. Is > > the > > > "Example Usage" section (which involves invoking the utility with a > > > namespace of "kafka.connect") actually meant to be part of the proposed > > > changes to public interface? > > > > > > Cheers, > > > > > > Chris > > > > > > On Mon, Jul 22, 2019 at 11:03 PM Arjun Satish <arjun.sat...@gmail.com> > > > wrote: > > > > > > > Hi everyone. > > > > > > > > I'd like to propose the following KIP to implement changing log > levels > > on > > > > the fly in Connect workers: > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-495%3A+Dynamically+Adjust+Log+Levels+in+Connect > > > > > > > > Would like to hear your thoughts on this. > > > > > > > > Thanks very much, > > > > Arjun > > > > > > > > > >
