Hi Jason, Thanks for the KIP! I've made a pass on it and here are few comments:
1. " before the clients which ." --> incomplete sentence? 2. " Any committed offset for a partition which is not currently subscribed to is subject to expiration." --> this may be an implementation detail, but are we going to piggy-back on the same offsetsRetentionCheckIntervalMs to check for expirable offsets as well? Some meta comment: 3. Looking into the current broker-side metrics, we do not have a good user visibility yet for offset removal either due to expiration or deletion, maybe we should consider adding one? 4. Playing the devil's advocate here: for cases where deleting expirable offsets is needed (like you mentioned lag monitoring), should we just by-pass the offset retention ms (by default it's one day) and remove immediately? What scenarios would require those non-subscribed partition offsets to be retained longer? Guozhang On Tue, Jul 23, 2019 at 10:11 AM Jason Gustafson <ja...@confluent.io> wrote: > Hi All, > > I have a short KIP to add an api for consumer offset deletion: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-496%3A+Administrative+API+to+delete+consumer+offsets > . > Please take a look and let me know what you think. > > Thanks, > Jason > -- -- Guozhang
