Thanks for the KIP! Overall, this makes sense and can simplify testing.
What I am wondering is, why you suggest to return an `Iterable`? Maybe returning an `Iterator` would make more sense? Or a List? Note that the order of emits matters, thus returning a generic `Collection` would not seem to be appropriate. Can you elaborate on the advantages to use `Iterable` compared to the other options? -Matthias On 4/11/19 2:09 AM, Patrik Kleindl wrote: > Hi everyone, > > I would like to start the discussion on this small enhancement of > the TopologyTestDriver. > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-451%3A+Make+TopologyTestDriver+output+iterable > > Pull request is available at https://github.com/apache/kafka/pull/6556 > > Any feedback is welcome > > best regards > > Patrik >
signature.asc
Description: OpenPGP digital signature
