Hello Mickael, segment.ms default value in TopicConfig is 7 days, I think this is a sufficient default value. Do you have any motivations to set it to -1?
Guozhang On Fri, Mar 29, 2019 at 9:42 AM Mickael Maison <mickael.mai...@gmail.com> wrote: > +1 (non binding) > For consistency, should we also set retention.ms to -1 instead of > Long.MAX_VALUE? > > On Fri, Mar 29, 2019 at 3:59 PM Manikumar <manikumar.re...@gmail.com> > wrote: > > > > +1 (binding) > > > > Thanks for the KIP. > > > > On Fri, Mar 29, 2019 at 9:04 PM Damian Guy <damian....@gmail.com> wrote: > > > > > +1 > > > > > > On Fri, 29 Mar 2019 at 01:59, John Roesler <j...@confluent.io> wrote: > > > > > > > +1 (nonbinding) from me. > > > > > > > > On Thu, Mar 28, 2019 at 7:08 PM Guozhang Wang <wangg...@gmail.com> > > > wrote: > > > > > > > > > Hello folks, > > > > > > > > > > I'd like to directly start a voting thread on this simple KIP to > change > > > > the > > > > > default override values for repartition topics: > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-443%3A+Return+to+default+segment.ms+and+segment.index.bytes+in+Streams+repartition+topics > > > > > > > > > > The related PR can be found here as well: > > > > > https://github.com/apache/kafka/pull/6511 > > > > > > > > > > If you have any thoughts or feedbacks, they are more than welcomed > as > > > > well. > > > > > > > > > > > > > > > -- Guozhang > > > > > > > > > > > > > -- -- Guozhang
