Hey there everybody, If there aren't any further comments, I will consider starting a VOTE thread in the following days.
Best, Stanislav On Thu, Jan 10, 2019 at 3:31 PM Ryanne Dolan <ryannedo...@gmail.com> wrote: > Makes sense, thanks. > > Ryanne > > On Wed, Jan 9, 2019, 11:28 PM Stanislav Kozlovski <stanis...@confluent.io > wrote: > > > Sorry about cutting the last message short. I was meaning to say that in > > the future we would be able to introduce finer-grained logging > > configuration (e.g enable debug logs for operations pertaining to this > > topic) and that would be easier to do if we are to know what the target > > resource of an IncrementalAlterConfig request is. > > > > Separating the resource types also allows us to not return a huge > > DescribeConfigs response on the BROKER resource type - the logging > > configurations can be quite verbose. > > > > I hope that answers your question > > > > Best, > > Stanislav > > > > On Wed, Jan 9, 2019 at 3:26 PM Stanislav Kozlovski < > stanis...@confluent.io > > > > > wrote: > > > > > Hey Ryanne, thanks for taking a look at the KIP! > > > > > > I think that it is useful to specify the distinction between a standard > > > Kafka config and the log level configs. The log level can be looked at > > as a > > > separate resource as it does not change the behavior of the Kafka > broker > > in > > > any way. > > > In terms of practical benefits, separating the two eases this KIP's > > > implementation and user's implementation of AlterConfigPolicy (e.g deny > > all > > > requests that try to alter log level) significantly. We would also be > > able > > > to introduce a > > > > > > On Wed, Jan 9, 2019 at 1:48 AM Ryanne Dolan <ryannedo...@gmail.com> > > wrote: > > > > > >> > To differentiate between the normal Kafka config settings and the > > >> application's log level settings, we will introduce a new resource > type > > - > > >> BROKER_LOGGERS > > >> > > >> Stanislav, can you explain why log level wouldn't be a "normal Kafka > > >> config > > >> setting"? > > >> > > >> Ryanne > > >> > > >> On Tue, Jan 8, 2019, 4:26 PM Stanislav Kozlovski < > > stanis...@confluent.io > > >> wrote: > > >> > > >> > Hey there everybody, > > >> > > > >> > I'd like to start a discussion about KIP-412. Please take a look at > > the > > >> KIP > > >> > if you can, I would appreciate any feedback :) > > >> > > > >> > KIP: KIP-412 > > >> > < > > >> > > > >> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-412%3A+Extend+Admin+API+to+support+dynamic+application+log+levels > > >> > > > > >> > JIRA: KAFKA-7800 <https://issues.apache.org/jira/browse/KAFKA-7800> > > >> > > > >> > -- > > >> > Best, > > >> > Stanislav > > >> > > > >> > > > > > > > > > -- > > > Best, > > > Stanislav > > > > > > > > > -- > > Best, > > Stanislav > > > -- Best, Stanislav
