Re: [DISCUSS] KIP-416: Notify SourceTask of ACK'd offsets, metadata

[Andrew Schofield]

As you might expect, I like the overloaded commitRecord() but I think the 
overloaded method should be called in exactly the same situations as the 
previous method. When it does not reflect an ACK, the second parameter could be 
null. The text of the KIP says that the overloaded method is only called when a 
record is ACKed and I would have thought that the connector implementor would 
want to provide only a single variant of commitRecord().

Andrew Schofield
IBM Event Streams

On 31/01/2019, 03:00, "Ryanne Dolan" <ryannedo...@gmail.com> wrote:

    I've updated the KIP and PR to overload commitRecord instead of adding a
    new method. Here's the PR:
    
    
https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fkafka%2Fpull%2F6171&amp;data=02%7C01%7C%7Cc627d954fa6f44574f7908d6872838c5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636845004151935856&amp;sdata=hxBWSTt5gF7AAVxw2P8%2BZ8duBB0T97gHOOYG6GCkdd8%3D&amp;reserved=0
    
    Ryanne
    
    On Mon, Jan 21, 2019 at 6:29 PM Ryanne Dolan <ryannedo...@gmail.com> wrote:
    
    > Andrew Schofield suggested we overload the commitRecord method instead of
    > adding a new one. Thoughts?
    >
    > Ryanne
    >
    > On Thu, Jan 17, 2019, 5:34 PM Ryanne Dolan <ryannedo...@gmail.com wrote:
    >
    >> I had to change the KIP number (concurrency is hard!) so the link is now:
    >>
    >>
    >> 
https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FKAFKA%2FKIP-416%253A%2BNotify%2BSourceTask%2Bof%2BACK%2527d%2Boffsets%252C%2Bmetadata&amp;data=02%7C01%7C%7Cc627d954fa6f44574f7908d6872838c5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636845004151935856&amp;sdata=VkAFrM8B2ozCRJosPQjgM3aDD1cS%2Bob8KWVuNuuOJ9s%3D&amp;reserved=0
    >>
    >> Ryanne
    >>
    >> On Fri, Jan 11, 2019 at 2:43 PM Ryanne Dolan <ryannedo...@gmail.com>
    >> wrote:
    >>
    >>> Hey y'all,
    >>>
    >>> Please review the following small KIP:
    >>>
    >>>
    >>> 
https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FKAFKA%2FKIP-414%253A%2BNotify%2BSourceTask%2Bof%2BACK%2527d%2Boffsets%252C%2Bmetadata&amp;data=02%7C01%7C%7Cc627d954fa6f44574f7908d6872838c5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636845004151945855&amp;sdata=2mhXA4hEV3ZvrFaOcTqagO1rYNj1JsYAEDHQsFqkzG8%3D&amp;reserved=0
    >>>
    >>> Thanks!
    >>> Ryanne
    >>>
    >>