The KIP doesn't discuss the option of using KafkaConsumer directly as far as I can tell. We have tried to avoid having the same functionality in multiple clients so it would be good to explain why this is necessary here (not saying it isn't).
Ismael On Mon, Jan 21, 2019, 10:29 AM Mickael Maison <mickael.mai...@gmail.com wrote: > Thanks Ryanne for the feedback, all suggestions sounded good, I've > updated the KIP accordingly. > > On Mon, Jan 21, 2019 at 3:43 PM Ryanne Dolan <ryannedo...@gmail.com> > wrote: > > > > +1 (non-binding) > > > > But I suggest: > > > > - drop "get" from getOffset, getTimestamp. > > > > - add to the motivation section why this is better than constructing a > > KafkaConsumer and using seek(), commit() etc. > > > > - add some rejected alternatives. > > > > Ryanne > > > > > > > > On Mon, Jan 21, 2019, 7:57 AM Dongjin Lee <dong...@apache.org wrote: > > > > > We have +4 non-binding for this vote. Is there any committer who is > > > interested in this issue? > > > > > > Thanks, > > > Dongjin > > > > > > On Mon, Jan 21, 2019 at 10:33 PM Andrew Schofield < > > > andrew_schofi...@live.com> > > > wrote: > > > > > > > +1 (non-binding). Thanks for the KIP. > > > > > > > > On 21/01/2019, 12:45, "Eno Thereska" <eno.there...@gmail.com> > wrote: > > > > > > > > +1 (non binding). Thanks. > > > > > > > > On Mon, Jan 21, 2019 at 12:30 PM Mickael Maison < > > > > mickael.mai...@gmail.com> > > > > wrote: > > > > > > > > > Bumping this thread. Considering this KIP is relatively straigh > > > > > forward, can we get some votes or feedback if you think it's > not? > > > > > Thanks > > > > > > > > > > On Tue, Jan 8, 2019 at 5:40 PM Edoardo Comar < > edoco...@gmail.com> > > > > wrote: > > > > > > > > > > > > +1 (non-binding) > > > > > > Thanks Mickael! > > > > > > > > > > > > On Tue, 8 Jan 2019 at 17:39, Patrik Kleindl < > pklei...@gmail.com> > > > > wrote: > > > > > > > > > > > > > +1 (non-binding) > > > > > > > Thanks, sounds very helpful > > > > > > > Best regards > > > > > > > Patrik > > > > > > > > > > > > > > > Am 08.01.2019 um 18:10 schrieb Mickael Maison < > > > > > mickael.mai...@gmail.com > > > > > > > >: > > > > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > > > I'd like to start the vote on KIP-396: > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fpages%2Fviewpage.action%3FpageId%3D97551484&data=02%7C01%7C%7C47c103e1919142c35d7c08d67f9e4c5d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636836715187389495&sdata=ihLaSXvB8C%2BK%2F%2BWjVDqKXgUJoRDmwfIi7FvFLRzmFe4%3D&reserved=0 > > > > > > > > > > > > > > > > Thanks > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > "When the people fear their government, there is tyranny; > when > > > the > > > > > > government fears the people, there is liberty." [Thomas > > > Jefferson] > > > > > > > > > > > > > > > > > > > > > > > -- > > > *Dongjin Lee* > > > > > > *A hitchhiker in the mathematical world.* > > > *github: <http://goog_969573159/>github.com/dongjinleekr > > > <https://github.com/dongjinleekr>linkedin: > kr.linkedin.com/in/dongjinleekr > > > <https://kr.linkedin.com/in/dongjinleekr>speakerdeck: > > > speakerdeck.com/dongjin > > > <https://speakerdeck.com/dongjin>* > > > > > > >
