Hi Neo,

thanks for the KIP, the proposal sounds useful!
Also I agree on both assumptions that you made:
 - users whose current truststore location starts with classpath: should be
very few and extremely far between (and arguably made questionable choices
when naming their files/directories), I personally think it is safe to
ignore these
 - this could also be useful for loading keystores, not just truststores

One additional idea maybe, looking at the Spring documentation they seem to
support filesystem, classpath and URL resources. Would it make sense to add
something to allow loading the truststore from a url as well when touching
this functionality?

Best regards,
Sönke


On Fri, Nov 30, 2018 at 6:01 PM Noa Resare <n...@resare.com> wrote:

> I wrote a KIP for my minimal suggested change to support reading a
> truststore from the classpath as well as from a file.
>
> The KIP is available here:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-398%3A+Support+reading+trust+store+from+classpath
> <
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-398:+Support+reading+trust+store+from+classpath
> >
>
> Any feedback or comments would be most welcome.
>
> Cheers
> Noa



-- 
Sönke Liebau
Partner
Tel. +49 179 7940878
OpenCore GmbH & Co. KG - Thomas-Mann-Straße 8 - 22880 Wedel - Germany

Reply via email to