Steff,
> Guess people have used it, assuming that all records that have been
polled > at the time of callback to "commit", have also had their offsets
committed. > But that is not true.
(excerpt from KIP)
The documentation for SourceTask.commit() reads:
> Commit the offsets, up to the offsets that have been returned by {@link
#poll()}. This > method should block until the commit is complete.
I'm confused by these seemingly contradictory statements. My assumption (as
you say) is that all records returned by poll() will have been committed
before commit() is invoked by the framework. Is that not the case?
Ryanne
On Wed, Oct 10, 2018 at 8:50 AM Per Steffensen <perst...@gmail.com> wrote:
> Please help make the proposed changes in KIP-381 become reality. Please
> comment.
>
> KIP:
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-381%3A+Connect%3A+Tell+about+records+that+had+their+offsets+flushed+in+callback
>
> JIRA: https://issues.apache.org/jira/browse/KAFKA-5716
>
> PR: https://github.com/apache/kafka/pull/3872
>
> Thanks!
>
>
>
