Thanks +1 (binding) On Sun, 23 Sep 2018 at 23:43 Edoardo Comar <eco...@uk.ibm.com> wrote:
> bumping the thread as the KIP needs 2 more binding votes ... pretty please > ... > -------------------------------------------------- > > Edoardo Comar > > IBM Event Streams > IBM UK Ltd, Hursley Park, SO21 2JN > > > > > From: "Skrzypek, Jonathan" <jonathan.skrzy...@gs.com> > To: "dev@kafka.apache.org" <dev@kafka.apache.org> > Date: 20/09/2018 17:08 > Subject: RE: [VOTE] KIP-302 - Enable Kafka clients to use all DNS > resolved IP addresses > > > > Ok thanks. > > +1 (non-binding) > > The only thing I'm not too sure about is the naming around configuration > entries for this, both for KIP-235 and KIP-302. > > KIP-235 expands DNS A records for bootstrap : > resolve.canonical.bootstrap.servers.only > KIP-302 expands DNS A records for advertised.listeners : use.all.dns.ips > > I'm a bit concerned that those don't easily explain what this does. > Documentation helps obviously, but would we have suggestions for better > naming ? > I'm fine if we go for those but worth thinking about I think. > > Also, we probably want a third option to have both ? That's why we > initially put in ".only" for KIP-235's parameter. > > Jonathan Skrzypek > > > -----Original Message----- > From: Edoardo Comar [mailto:eco...@uk.ibm.com] > Sent: 20 September 2018 09:55 > To: dev@kafka.apache.org > Subject: RE: [VOTE] KIP-302 - Enable Kafka clients to use all DNS resolved > IP addresses > > Hi Jonathan > we'll update the PR for KIP-302 soon. We do not need KIP-235 actually, > they only share the name of the configuration entry. > > thanks > Edo > > PS - we need votes :-) > > -------------------------------------------------- > > Edoardo Comar > > IBM Message Hub > > IBM UK Ltd, Hursley Park, SO21 2JN > > > > From: "Skrzypek, Jonathan" <jonathan.skrzy...@gs.com> > To: "dev@kafka.apache.org" <dev@kafka.apache.org> > Date: 19/09/2018 16:12 > Subject: ***UNCHECKED*** RE: [VOTE] KIP-302 - Enable Kafka clients > to use all DNS resolved IP addresses > > > > I'm assuming this needs KIP-235 to be merged. > Unfortunately I've tripped over some merge issues with git and struggled > to fix. > Hopefully this is fixed but any help appreciated : > https://github.com/apache/kafka/pull/4485 > > > > Jonathan Skrzypek > > > > -----Original Message----- > From: Eno Thereska [mailto:eno.there...@gmail.com] > Sent: 19 September 2018 11:01 > To: dev@kafka.apache.org > Subject: Re: [VOTE] KIP-302 - Enable Kafka clients to use all DNS resolved > IP addresses > > +1 (non-binding). > > Thanks > Eno > > On Wed, Sep 19, 2018 at 10:09 AM, Rajini Sivaram <rajinisiva...@gmail.com> > wrote: > > > Hi Edo, > > > > Thanks for the KIP! > > > > +1 (binding) > > > > On Tue, Sep 18, 2018 at 3:51 PM, Edoardo Comar <eco...@uk.ibm.com> > wrote: > > > > > Hi All, > > > > > > I'd like to start the vote on KIP-302: > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > > > 302+-+Enable+Kafka+clients+to+use+all+DNS+resolved+IP+addresses > > > > > > We'd love to get this in 2.1.0 > > > Kip freeze is just a few days away ... please cast your votes :-):-) > > > > > > Thanks!! > > > Edo > > > > > > -------------------------------------------------- > > > > > > Edoardo Comar > > > > > > IBM Message Hub > > > > > > IBM UK Ltd, Hursley Park, SO21 2JN > > > Unless stated otherwise above: > > > IBM United Kingdom Limited - Registered in England and Wales with > number > > > 741598. > > > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 > > 3AU > > > > > > > ________________________________ > > Your Personal Data: We may collect and process information about you that > may be subject to data protection laws. For more information about how we > use and disclose your personal data, how we protect your information, our > legal basis to use your information, your rights and who you can contact, > please refer to: > http://www.gs.com/privacy-notices > < > http://www.gs.com/privacy-notices > > > > > > > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU > > ________________________________ > > Your Personal Data: We may collect and process information about you that > may be subject to data protection laws. For more information about how we > use and disclose your personal data, how we protect your information, our > legal basis to use your information, your rights and who you can contact, > please refer to: www.gs.com/privacy-notices< > http://www.gs.com/privacy-notices > > > > > > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU >
