+1 (binding) On Tue, 18 Sep 2018 at 16:33 Bill Bejeck <bbej...@gmail.com> wrote:
> All, > > In starting work on the PR for KIP-372, the Grouped interface needed some > method renaming to be more consistent with the other configuration classes > (Joined, Produced, etc.). As such I've updated the Grouped code section of > the KIP. > > As these changes address a comment from Matthias on the initial draft of > the KIP and don't change any of the existing behavior already outlined, I > don't think a re-vote is required. > > Thanks, > Bill > > On Tue, Sep 18, 2018 at 10:09 AM John Roesler <j...@confluent.io> wrote: > > > +1 (non-binding) > > > > Thanks! > > > > On Mon, Sep 17, 2018 at 7:29 PM Dongjin Lee <dong...@apache.org> wrote: > > > > > Great improvements. +1. (Non-binding) > > > > > > On Tue, Sep 18, 2018 at 5:14 AM Matthias J. Sax <matth...@confluent.io > > > > > wrote: > > > > > > > +1 (binding) > > > > > > > > -Matthias > > > > > > > > On 9/17/18 1:12 PM, Guozhang Wang wrote: > > > > > +1 from me, thanks Bill ! > > > > > > > > > > On Mon, Sep 17, 2018 at 12:43 PM, Bill Bejeck <bbej...@gmail.com> > > > wrote: > > > > > > > > > >> All, > > > > >> > > > > >> I'd like to start the voting process for KIP-372. Here's the link > > to > > > > the > > > > >> updated proposal > > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > > >> 372%3A+Naming+Repartition+Topics+for+Joins+and+Grouping > > > > >> > > > > >> I'll start with my own +1. > > > > >> > > > > >> Thanks, > > > > >> Bill > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > *Dongjin Lee* > > > > > > *A hitchhiker in the mathematical world.* > > > > > > *github: <http://goog_969573159/>github.com/dongjinleekr > > > <http://github.com/dongjinleekr>linkedin: > > kr.linkedin.com/in/dongjinleekr > > > <http://kr.linkedin.com/in/dongjinleekr>slideshare: > > > www.slideshare.net/dongjinleekr > > > <http://www.slideshare.net/dongjinleekr>* > > > > > >
