I see! Thanks for the explanation Matt. On Sun, 16 Sep 2018 at 20:10 Matthias J. Sax <matth...@confluent.io> wrote:
> People cannot pick if their vote is binding or not. If a committer > (https://kafka.apache.org/committers) votes, it's binding; otherwise, not. > > Thus, there is no default -- it depends who votes. > > > -Matthias > > > On 9/13/18 2:41 PM, Joan Goyeau wrote: > > Ok so a +1 is non binding by default. > > > > On Tue, 11 Sep 2018 at 17:25 Matthias J. Sax <matth...@confluent.io> > wrote: > > > >> I only count 3 binding votes (Guozhang, Matthias, Damian). Plus 4 > >> non-binding (John, Ted, Bill, Dongjin) -- or 5 if you vote your own KIP > :) > >> > >> -Matthias > >> > >> On 9/11/18 12:53 AM, Joan Goyeau wrote: > >>> Ok, so this is now accepted. > >>> > >>> Binding votes: +5 > >>> Non-binding votes: +2 > >>> > >>> Thanks > >>> > >>> On Wed, 5 Sep 2018 at 21:38 John Roesler <j...@confluent.io> wrote: > >>> > >>>> Hi Joan, > >>>> > >>>> Damian makes 3 binding votes, and the vote has been open longer than > 72 > >>>> hours, so your KIP vote has passed! > >>>> > >>>> It's customary for you to send a final reply to this thread stating > that > >>>> the vote has passed, and stating the number of binding and non-binding > >> +1s. > >>>> > >>>> Also please update the current state to Accepted here: > >>>> > >>>> > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-365%3A+Materialized%2C+Serialized%2C+Joined%2C+Consumed+and+Produced+with+implicit+Serde > >>>> > >>>> And move your kip into the Adopted table here: > >>>> > >>>> > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-365%3A+Materialized%2C+Serialized%2C+Joined%2C+Consumed+and+Produced+with+implicit+Serde > >>>> (release will be 2.1) > >>>> > >>>> And finally, move it to Accepted here: > >>>> https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Streams > >>>> > >>>> Lastly, you might want to make another pass over the PR and call for > >> final > >>>> reviews. > >>>> > >>>> Thanks so much for managing this process, > >>>> -John > >>>> > >>>> On Mon, Sep 3, 2018 at 11:00 AM Damian Guy <damian....@gmail.com> > >> wrote: > >>>> > >>>>> +1 > >>>>> > >>>>> On Sun, 2 Sep 2018 at 15:20 Matthias J. Sax <matth...@confluent.io> > >>>> wrote: > >>>>> > >>>>>> +1 (binding) > >>>>>> > >>>>>> On 9/1/18 2:40 PM, Guozhang Wang wrote: > >>>>>>> +1 (binding). > >>>>>>> > >>>>>>> On Mon, Aug 27, 2018 at 5:20 PM, Dongjin Lee <dong...@apache.org> > >>>>> wrote: > >>>>>>> > >>>>>>>> +1 (non-binding) > >>>>>>>> > >>>>>>>> On Tue, Aug 28, 2018 at 8:53 AM Bill Bejeck <bbej...@gmail.com> > >>>>> wrote: > >>>>>>>> > >>>>>>>>> +1 > >>>>>>>>> > >>>>>>>>> -Bill > >>>>>>>>> > >>>>>>>>> On Mon, Aug 27, 2018 at 3:24 PM Ted Yu <yuzhih...@gmail.com> > >>>> wrote: > >>>>>>>>> > >>>>>>>>>> +1 > >>>>>>>>>> > >>>>>>>>>> On Mon, Aug 27, 2018 at 12:18 PM John Roesler < > j...@confluent.io> > >>>>>>>> wrote: > >>>>>>>>>> > >>>>>>>>>>> +1 (non-binding) > >>>>>>>>>>> > >>>>>>>>>>> On Sat, Aug 25, 2018 at 1:16 PM Joan Goyeau <j...@goyeau.com> > >>>>> wrote: > >>>>>>>>>>> > >>>>>>>>>>>> Hi, > >>>>>>>>>>>> > >>>>>>>>>>>> We want to make sure that we always have a serde for all > >>>>>>>>> Materialized, > >>>>>>>>>>>> Serialized, Joined, Consumed and Produced. > >>>>>>>>>>>> For that we can make use of the implicit parameters in Scala. > >>>>>>>>>>>> > >>>>>>>>>>>> KIP: > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>> > >>>>>>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP- > >>>>>>>> > >>>>>> > >>>>> > >>>> > >> > 365%3A+Materialized%2C+Serialized%2C+Joined%2C+Consumed+and+Produced+with+ > >>>>>>>> implicit+Serde > >>>>>>>>>>>> > >>>>>>>>>>>> Github PR: https://github.com/apache/kafka/pull/5551 > >>>>>>>>>>>> > >>>>>>>>>>>> Please make your votes. > >>>>>>>>>>>> Thanks > >>>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>> > >>>>>>>>> > >>>>>>>>> -- > >>>>>>>>> *Dongjin Lee* > >>>>>>>>> > >>>>>>>>> *A hitchhiker in the mathematical world.* > >>>>>>>>> > >>>>>>>>> *github: <http://goog_969573159/>github.com/dongjinleekr > >>>>>>>>> <http://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/ > >>>>>>>> dongjinleekr > >>>>>>>>> <http://kr.linkedin.com/in/dongjinleekr>slideshare: > >>>>>> www.slideshare.net/ > >>>>>>>> dongjinleekr > >>>>>>>>> <http://www.slideshare.net/dongjinleekr>* > >>>>>>>>> > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > >> > > > >