+1 Thanks for the KIP! I'd suggest mentioning the configurations that were previously proposed in the rejected alternatives section. We may reconsider them in the future.
On Mon, Aug 13, 2018 at 9:48 AM, Dhruvil Shah <[email protected]> wrote: > Thanks for the KIP, Stanislav! +1 (non-binding) > > - Dhruvil > > On Mon, Aug 13, 2018 at 9:39 AM Colin McCabe <[email protected]> wrote: > > > +1 (non-binding) > > > > best, > > Colin > > > > On Tue, Aug 7, 2018, at 04:19, Stanislav Kozlovski wrote: > > > Hey everybody, > > > I'm starting a vote on KIP-346 > > > < > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 346+-+Improve+LogCleaner+behavior+on+error > > > > > > > > > -- > > > Best, > > > Stanislav > > >
