Yishun, some more comments: 1. "All the coordinator ids " + "for this request": it should be "all the requested group ids looking for their coordinators" right?
2. I just thought about this a bit more, regarding "*Compatibility issues between old and new versions need to be considered, we should think about how to convert requests from a newer version to a old version."* One thing I realized is that for FindCoordinatorRequest, today both consumer / admin client would need it. I.e. to complete the KIP for compatibility, you'll have to implement this function along with this KIP, since otherwise consumer talking to an old broker will fail to. So I'd suggest you update the `Compatibility` section with a detailed proposal on how to let new versioned clients to talk to old versioned brokers. We've talked about some high-level implementation guidelines in the DISCUSS thread, which you can try it out and see if it works: i.e. by starting a Kafka broker with version 2.0, and then starting a consumer client with trunk (it will have a new version), and the added logic should make sure the consumer still proceeds normally with the compatibility logic that we are going to add. Guozhang On Thu, Aug 16, 2018 at 5:46 PM, Hu Xi <huxi...@hotmail.com> wrote: > +1 (non-binding) > > ________________________________ > 发件人: Yishun Guan <gyis...@gmail.com> > 发送时间: 2018年8月17日 8:14 > 收件人: dev@kafka.apache.org > 主题: [VOTE] KIP-347: Enable batching in FindCoordinatorRequest > > Hi all, > > I want to start a vote on this KIP: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 347%3A++Enable+batching+in+FindCoordinatorRequest > > Here is the discussion thread: > https://lists.apache.org/thread.html/fd727cc7d5b0956d64255c35d5ed46 > 403c3495a7052ba8ffbc55e084@%3Cdev.kafka.apache.org%3E > > Thanks everyone for your input! > > Best, > Yishun > -- -- Guozhang
