Thanks all for the suggestions. I'll work to make changes Regards, Ratish
On Sat, Aug 4, 2018 at 2:20 PM Attila Sasvári <asasv...@apache.org> wrote: > Thanks for the KIP. > > Regarding the motivation: > - KIP-113 added a new command, kafka-log-dirs.sh, to get the partitions > associated with a specific broker (however, it does not work on secured > clusters, see KIP-340). > > It would be probably better/more flexible if you could specify multiple > broker ids. For example, we could use a command option like --broker-list > (to be consistent with kafka-log-dirs.sh). > > --list only lists the topics. If you want to get the list of partition, you > would need --describe. I agree with Colin to document error conditions. > > Best regards, > Attila > > > > On Sat, Aug 4, 2018 at 1:03 AM Colin McCabe <cmcc...@apache.org> wrote: > > > Thanks for the KIP, Ratish. > > > > We should probably specify that it is an error when --broker is specified > > with operations other than --list, right? > > > > best, > > Colin > > > > > > On Wed, Aug 1, 2018, at 21:28, Ratish Ravindran wrote: > > > Hi, > > > > > > I would like to open a discussion thread on KIP-350: > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-350%3A+Allow+kafka-topics.sh+to+take+brokerid+as+parameter+to+show+partitions+associated+with+it > > > > > > This is KIP is to add the optional brokerid parameter in > kafka-topics.sh, > > > to only get the partition associated with that specific broker. > > Current,ly > > > we use grep to do so. > > > > > > Let me know your thoughts and suggestions. > > > > > > Thanks, > > > Ratish > > >
