Hi all,
Since we are going to use "command-config" as the option name in KIP-332, I
have updated the KIP to use "command-config" for consistency.
Please comment if you think "config-file" is better.
Thanks,
Dong
On Fri, Aug 3, 2018 at 2:39 AM, Manikumar <manikumar.re...@gmail.com> wrote:
> Hi Dong,
>
> In KIP-332 discussion, It was agreed to use "--command-config" option name
> for passing config property file.
> We can also use same name in here, to make it consistent across all
> tools.
>
> Thanks,
>
> On Thu, Jul 12, 2018 at 9:20 AM Dong Lin <lindon...@gmail.com> wrote:
>
> > wiki page is currently read-only and it is unavailable for write
> operation.
> > Will update it later.
> >
> > On Wed, Jul 11, 2018 at 8:48 PM, Dong Lin <lindon...@gmail.com> wrote:
> >
> > > Ah I see. Thanks for the suggestion. It is updated now.
> > >
> > > On Wed, Jul 11, 2018 at 8:13 PM, Ted Yu <yuzhih...@gmail.com> wrote:
> > >
> > >> bq. the same approach used by "--config-file" in ConfigCommand.
> > >>
> > >> I should have copied more from the KIP.
> > >> What I meant was that ConfigCommand doesn't use "--config-file"
> option.
> > So
> > >> 'same approach' implies StreamsResetter class, not ConfigCommand.
> > >>
> > >> I didn't mean to change ConfigCommand w.r.t. name of the option.
> > >>
> > >> Cheers
> > >>
> > >> On Wed, Jul 11, 2018 at 8:06 PM Dong Lin <lindon...@gmail.com> wrote:
> > >>
> > >> > Do you mean we should replace "--command-config" with
> "--config-file"
> > in
> > >> > ConfigCommand? There is backward compatibility concern with the
> > change.
> > >> I
> > >> > am not sure the benefit of this change is worth the effort to
> > deprecate
> > >> the
> > >> > old config. Maybe we should do it separately if more people thing it
> > is
> > >> > necessary?
> > >> >
> > >> > On Wed, Jul 11, 2018 at 8:01 PM, Ted Yu <yuzhih...@gmail.com>
> wrote:
> > >> >
> > >> > > bq. "--config-file" in ConfigCommand.
> > >> > >
> > >> > > Please update the above - it should be StreamsResetter
> > >> > >
> > >> > >
> > >> > > On Wed, Jul 11, 2018 at 7:59 PM Dong Lin <lindon...@gmail.com>
> > wrote:
> > >> > >
> > >> > > > Hey Ted,
> > >> > > >
> > >> > > > Thanks much for the suggestion. Yeah "config-file" looks better
> > than
> > >> > > > "command-config". I have updated the KIP as suggested.
> > >> > > >
> > >> > > > Thanks,
> > >> > > > Dong
> > >> > > >
> > >> > > > On Wed, Jul 11, 2018 at 5:57 PM, Ted Yu <yuzhih...@gmail.com>
> > >> wrote:
> > >> > > >
> > >> > > > > Looking at StreamsResetter.java :
> > >> > > > >
> > >> > > > > commandConfigOption = optionParser.accepts("config-
> file",
> > >> > > > "Property
> > >> > > > > file containing configs to be passed to admin cl
> > >> > > > >
> > >> > > > > Not sure you have considered naming the option in the above
> > >> fashion.
> > >> > > > >
> > >> > > > > Probably add the above to Alternative section.
> > >> > > > >
> > >> > > > > Cheers
> > >> > > > >
> > >> > > > > On Wed, Jul 11, 2018 at 2:04 PM Dong Lin <lindon...@gmail.com
> >
> > >> > wrote:
> > >> > > > >
> > >> > > > > > Hi all,
> > >> > > > > >
> > >> > > > > > I have created KIP-340: Allow kafka-reassign-partitions.sh
> and
> > >> > > > > > kafka-log-dirs.sh to take admin client property file. See
> > >> > > > > >
> > >> > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > >> > > > > 340%3A+Allow+kafka-reassign-partitions.sh+and+kafka-log-
> > >> > > > > dirs.sh+to+take+admin+client+property+file
> > >> > > > > > .
> > >> > > > > >
> > >> > > > > > This KIP provides a way to allow
> kafka-reassign-partitions.sh
> > >> and
> > >> > > > > > kafka-log-dirs.sh to talk to broker over SSL. Please review
> > the
> > >> KIP
> > >> > > if
> > >> > > > > you
> > >> > > > > > have time.
> > >> > > > > >
> > >> > > > > >
> > >> > > > > > Thanks!
> > >> > > > > > Dong
> > >> > > > > >
> > >> > > > >
> > >> > > >
> > >> > >
> > >> >
> > >>
> > >
> > >
> >
>
