Hi Mickael, Thanks for the suggestion!
Correct me if I am mistaken, but if a producer attempts to send to a partition that is under min ISR (and ack=all or -1) then the send will fail with a NotEnoughReplicas or NotEnoughReplicasAfterAppend exception? At this point, client-side has already suffered failure but the server-side is still fine for now? If the above is true, then this would be a FATAL case for producers. Would it be valuable to include the CRITICAL case where a topic partition has exactly min ISR so that Kafka operators can take action so it does not become FATAL? This could be in the same option or a new one. Thanks! Regards, Kevin On Thu, Aug 2, 2018 at 2:27 AM Mickael Maison <mickael.mai...@gmail.com> wrote: > What about also adding a --under-minisr-partitions option? > > That would match the > "kafka.server:type=ReplicaManager,name=UnderMinIsrPartitionCount" > broker metric and it's usually pretty relevant when investigating > issues > > On Thu, Aug 2, 2018 at 8:54 AM, Kevin Lu <lu.ke...@berkeley.edu> wrote: > > Hi friends! > > > > This thread is to discuss KIP-351 > > < > https://cwiki.apache.org/confluence/display/KAFKA/KIP-351%3A+Add+--critical-partitions+option+to+describe+topics+command > > > > ! > > > > I am proposing to add a --critical-partitions option to the describe > topics > > command that will only list out topic partitions that have 1 ISR left > (RF > > > 1) as they would be in a critical state and need immediate > repartitioning. > > > > I wonder if the name "critical" is appropriate? > > > > Thoughts? > > > > Thanks! > > > > Regards, > > Kevin >
