Thanks, +1 from me. On Fri, Jul 20, 2018 at 11:41 AM, Manikumar <manikumar.re...@gmail.com> wrote:
> Thanks for the feedback, sounds good to me. Updated the KIP. > > On Sat, Jul 21, 2018 at 12:04 AM Jason Gustafson <ja...@confluent.io> > wrote: > > > After thinking about it, perhaps a better option is INVALID_REQUEST? I > > think this is usually used for requests which are malformed in some way, > so > > it's a slight abuse, but at least it suggests an incompatibility between > > what the client is requesting to do and what the server supports. > > UNKNOWN_SERVER_ERROR, on the other hand, suggests an unexpected condition > > on the broker. > > > > -Jason > > > > On Fri, Jul 20, 2018 at 10:57 AM, Manikumar <manikumar.re...@gmail.com> > > wrote: > > > > > Hi Jason, > > > > > > Yes, we can return UNKNOWN_SERVER_ERROR for older versions. > > > This will give better developer experience. Updated the KIP. > > > > > > Thanks, > > > > > > On Fri, Jul 20, 2018 at 11:02 PM Jason Gustafson <ja...@confluent.io> > > > wrote: > > > > > > > Hey Manikumar, > > > > > > > > This looks good. Do we have to keep the current behavior when > handling > > > old > > > > DeleteTopics versions? I'm wondering if it would be better to return > an > > > > UNKNOWN_ERROR (say) and let the client raise that to the user instead > > of > > > > just timing out. > > > > > > > > Thanks, > > > > Jason > > > > > > > > On Fri, Jul 20, 2018 at 10:00 AM, Manikumar < > manikumar.re...@gmail.com > > > > > > > wrote: > > > > > > > > > Bumping this thread. > > > > > > > > > > On Tue, Jul 10, 2018 at 10:33 PM Manikumar < > > manikumar.re...@gmail.com> > > > > > wrote: > > > > > > > > > > > Waiting for one more binding vote to pass this minor KIP. > > Appreciate > > > > > your > > > > > > vote. > > > > > > > > > > > > On Wed, Jul 4, 2018 at 7:03 PM Eno Thereska < > > eno.there...@gmail.com> > > > > > > wrote: > > > > > > > > > > > >> +1 (non binding) > > > > > >> > > > > > >> On Wed, Jul 4, 2018 at 1:19 PM, Kamal Chandraprakash < > > > > > >> kamal.chandraprak...@gmail.com> wrote: > > > > > >> > > > > > >> > +1 (non-binding) > > > > > >> > > > > > > >> > On Wed, Jul 4, 2018 at 5:22 PM Magnus Edenhill < > > > mag...@edenhill.se> > > > > > >> wrote: > > > > > >> > > > > > > >> > > +1 (non-binding) > > > > > >> > > > > > > > >> > > 2018-07-04 13:40 GMT+02:00 Satish Duggana < > > > > satish.dugg...@gmail.com > > > > > >: > > > > > >> > > > > > > > >> > > > +1 > > > > > >> > > > > > > > > >> > > > Thanks, > > > > > >> > > > Satish. > > > > > >> > > > > > > > > >> > > > On Wed, Jul 4, 2018 at 4:11 PM, Daniele Ascione < > > > > > >> ascion...@gmail.com> > > > > > >> > > > wrote: > > > > > >> > > > > > > > > >> > > > > +1 > > > > > >> > > > > > > > > > >> > > > > Thanks, > > > > > >> > > > > Daniele > > > > > >> > > > > > > > > > >> > > > > Il giorno mar 3 lug 2018 alle ore 23:55 Harsha < > > > > ka...@harsha.io > > > > > > > > > > > >> ha > > > > > >> > > > > scritto: > > > > > >> > > > > > > > > > >> > > > > > +1. > > > > > >> > > > > > > > > > > >> > > > > > Thanks, > > > > > >> > > > > > Harsha > > > > > >> > > > > > > > > > > >> > > > > > On Tue, Jul 3rd, 2018 at 9:22 AM, Ted Yu < > > > > yuzhih...@gmail.com > > > > > > > > > > > >> > > wrote: > > > > > >> > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > +1 > > > > > >> > > > > > > > > > > > >> > > > > > > On Tue, Jul 3, 2018 at 9:05 AM, Mickael Maison < > > > > > >> > > > > > mickael.mai...@gmail.com > > > > > > >> > > > > > > > > > > > >> > > > > > > wrote: > > > > > >> > > > > > > > > > > > >> > > > > > > > +1 (non binding) > > > > > >> > > > > > > > Thanks for the KIP > > > > > >> > > > > > > > > > > > > >> > > > > > > > On Tue, Jul 3, 2018 at 4:59 PM, Vahid S Hashemian > > > > > >> > > > > > > > < vahidhashem...@us.ibm.com > wrote: > > > > > >> > > > > > > > > +1 (non-binding) > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > --Vahid > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > From: Gwen Shapira < g...@confluent.io > > > > > > >> > > > > > > > > To: dev < dev@kafka.apache.org > > > > > > >> > > > > > > > > Date: 07/03/2018 08:49 AM > > > > > >> > > > > > > > > Subject: Re: [VOTE] KIP-322: Return new error > code > > > for > > > > > >> > > > > > > > DeleteTopics > > > > > >> > > > > > > > > API when topic deletion disabled. > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > +1 > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > On Tue, Jul 3, 2018 at 8:24 AM, Manikumar < > > > > > >> > > > > > manikumar.re...@gmail.com > > > > > > >> > > > > > > > > > > > >> > > > > > > > > wrote: > > > > > >> > > > > > > > > > > > > > >> > > > > > > > >> Manikumar < manikumar.re...@gmail.com > > > > > > >> > > > > > > > >> Fri, Jun 29, 7:59 PM (4 days ago) > > > > > >> > > > > > > > >> to dev > > > > > >> > > > > > > > >> Hi All, > > > > > >> > > > > > > > >> > > > > > >> > > > > > > > >> I would like to start voting on KIP-322 which > > would > > > > > >> return > > > > > >> > new > > > > > >> > > > > error > > > > > >> > > > > > > > > code > > > > > >> > > > > > > > >> for DeleteTopics API when topic deletion > > disabled. > > > > > >> > > > > > > > >> > > > > > >> > > > > > > > >> > > > > > >> > > > > > > > > > > https://cwiki.apache.org/confluence/pages/viewpage. > > > > > >> > > > > > > > action?pageId=87295558 > > > > > >> > > > > > > > > > > > > > >> > > > > > > > >> > > > > > >> > > > > > > > >> Thanks, > > > > > >> > > > > > > > >> > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > -- > > > > > >> > > > > > > > > *Gwen Shapira* > > > > > >> > > > > > > > > Product Manager | Confluent > > > > > >> > > > > > > > > 650.450.2760 | @gwenshap > > > > > >> > > > > > > > > Follow us: Twitter < > > > > > >> > > > > > > > > https://twitter.com/ConfluentInc > > > > > >> > > > > > > > >> | blog > > > > > >> > > > > > > > > < > > > > > >> > > > > > > > > http://www.confluent.io/blog > > > > > >> > > > > > > > >> > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > > > > > > > > > > > > > > > > >
