Hello Ted, That's my fault. I replied in the PR because at the time John had made his comment I hadn't added myself to the dev email list to reply. You can see my comment here.
https://github.com/apache/kafka/pull/5284#discussion_r199360544 There is still ongoing discussion about the purpose of TopologyDescription. Some parts of TopologyDescription might need to be worked so that the return types are not strings, but TopologyDescription will continue to print the human readable descriptions of the Topology by implicitly calling the toString method of the underlying object. Please, view the discussion thread for more details. However, I believe this KIP is finished and the other changes might need to be part of another KIP. Best, Nishanth Pradeep On Tue, Jul 3, 2018 at 10:54 PM, Ted Yu <yuzhih...@gmail.com> wrote: > Hi, > I don't seem to find response to John's comment : > > http://search-hadoop.com/m/Kafka/uyzND11alrn1G5N3Y1?subj= > Re+Discuss+KIP+321+Add+method+to+get+TopicNameExtractor+in+ > TopologyDescription > > On Tue, Jul 3, 2018 at 7:38 PM, Nishanth Pradeep <nishanth...@gmail.com> > wrote: > > > Hello, > > > > I would like to start the vote on extending the TopologyDescription.Sink > > interface to return the class of the TopicNameExtractor in cases where > > dynamic routing is used. > > > > The user can override the toString method of the TopicNameExtractor class > > in order to provide a better textual description if he or she chooses. > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 321%3A+Add+method+to+get+TopicNameExtractor+in+TopologyDescription > > > > Best, > > Nishanth Pradeep > > >
