Since this is a minor KIP, If there are no concerns I will start voting thread.
On Wed, Jun 27, 2018 at 2:24 PM Ted Yu <yuzhih...@gmail.com> wrote: > bq. set the serialVersionUID = 1L in Kafka exception classes > > Indeed. Should have checked earlier. > > On Wed, Jun 27, 2018 at 1:38 AM, Manikumar <manikumar.re...@gmail.com> > wrote: > > > Hi, > > > > Thanks for the review. > > > > > > > nit: you are going to fill in an actual value below in your PR, right ? > > > private static final long serialVersionUID = 1L; > > > > > > > > We normally set the serialVersionUID = 1L in Kafka exception classes. > > > > In Motivation, please mention the IllegalStateException scenario. > > > > > > > IllegalStateException mentioned in the JIRA is specific to user > > implementaion. > > Main issue is we wont get response form the server. In this case, admin > > client times out the requests. > > >
