+1 On Tue, 26 Jun 2018 at 17:22 Bill Bejeck <bbej...@gmail.com> wrote:
> +1 > > On Mon, Jun 25, 2018 at 11:07 PM Matthias J. Sax <matth...@confluent.io> > wrote: > > > +1 (binding) > > > > On 6/25/18 3:00 PM, Guozhang Wang wrote: > > > +1 > > > > > > On Mon, Jun 25, 2018 at 2:58 PM, Ted Yu <yuzhih...@gmail.com> wrote: > > > > > >> +1 > > >> > > >> On Mon, Jun 25, 2018 at 2:56 PM, John Roesler <j...@confluent.io> > > wrote: > > >> > > >>> Hello All, > > >>> > > >>> Thanks for the discussion on KIP-319. I'd now like to start the > voting. > > >>> > > >>> As a reminder, KIP-319 proposes a fix to an issue I identified in > > >>> KAFKA-7080. Specifically, the issue is that we're creating > > >>> CachingWindowStore with the *number of segments* instead of the > > *segment > > >>> size*. > > >>> > > >>> Here's the jira: https://issues.apache.org/jira/browse/KAFKA-7080 > > >>> Here's the KIP: https://cwiki.apache.org/confluence/x/mQU0BQ > > >>> > > >>> Additionally, here's a draft PR for clarity: > > >>> https://github.com/apache/kafka/pull/5257 > > >>> > > >>> Thanks, > > >>> -John > > >>> > > >> > > > > > > > > > > > > > >
