Looks like my understanding of decaying metrics was wrong, could not get the viable example. The difference in values when marking one metric 10k times, and then marking the other 10k after 1 minute were to the order of 10^-12, what is not interesting.
So, I had updated the pull request accordingly (removed the Replication* metric). I am wondering whether it would be preferable to have the removed replication metric visible (however that would need to be view-metric that would perform the subtraction, and most probably would force subclassing MetricRegistry at (com.yammer.metrics.Metrics.DEFAULT_REGISTRY)- its generic getOrAdd method is protected). AK~ 2018-05-02 16:11 GMT+01:00 Ted Yu <yuzhih...@gmail.com>: > Can you explain Rejected Alternatives #2 in more detail ? > > Maybe give some concrete example to show the summation of the two new > metrics is not equal to the existing metric. > > On Wed, May 2, 2018 at 6:49 AM, Adam Kotwasinski < > adam.kotwasin...@gmail.com > > wrote: > > > Hello, > > > > I have created a KIP to add some additional metrics re number of fetch > > requests made to brokers - > > https://cwiki.apache.org/confluence/pages/viewpage. > action?pageId=80452537 > > > > Feedback and suggestions are welcome. > > > > Best regards, > > Adam Kotwasinski > > >
