I was just reading the whole KIP for the first time. Nice work!
One minor comment. In the table of the standalone consumer, the first
line, first column says:
> = Empty
> (protocolType = Some("consumer"))
I think this should be
> = Empty
> (protocolType != None)
Note, that for example KafkaStreams uses a different protocol type
(namely "stream"). Also, other consumer must implement their own
partition assignors, too, with other names.
-Matthias
On 3/26/18 1:44 PM, Vahid S Hashemian wrote:
> Hi all,
>
> Thanks for the feedback on this KIP so far.
>
> If there is no additional feedback, I'll start a vote on Wed.
>
> Thanks.
> --Vahid
>
>
signature.asc
Description: OpenPGP digital signature
