Thanks for working on it Viktor. It looks good to me, but I have some questions: - I see a new type DOUBLE is used for quota_value , and it is not listed among the primitive types on the Kafka protocol guide. Can you add some more details? - I am not sure that using an environment (i.e. USE_OLD_COMMAND)variable is the best way to control behaviour of kafka-config.sh . In other scripts (e.g. console-consumer) an argument is passed (e.g. --new-consumer). If we still want to use it, then I would suggest something like USE_OLD_KAFKA_CONFIG_COMMAND. What do you think? - I have seen maps like Map<List<ConfigResource>, Collection<QuotaType>>. If List<ConfigResource> is the key type, you should make sure that this List is immutable. Have you considered to introduce a new wrapper class?
Regards, - Attila On Thu, Mar 29, 2018 at 1:46 PM, zhenya Sun <toke...@126.com> wrote: > > > > +1 （non-binding） > > > | | > zhenya Sun > 邮箱：toke...@126.com > | > > 签名由 网易邮箱大师 定制 > > On 03/29/2018 19:40, Sandor Murakozi wrote: > +1 (non-binding) > > Thanks for the KIP, Viktor > > On Wed, Mar 21, 2018 at 5:41 PM, Viktor Somogyi <viktorsomo...@gmail.com> > wrote: > > > Hi Everyone, > > > > I've started a vote on KIP-248 > > <https://cwiki.apache.org/confluence/display/KAFKA/KIP-248+-+Create+New+ > > ConfigCommand+That+Uses+The+New+AdminClient#KIP-248- > > CreateNewConfigCommandThatUsesTheNewAdminClient-DescribeQuotas> > > a few weeks ago but at the time I got a couple more comments and it was > > very close to 1.1 feature freeze, people were occupied with that, so I > > wanted to restart the vote on this. > > > > > > *Summary of the KIP* > > For those who don't have context I thought I'd summarize it in a few > > sentence. > > *Problem & Motivation: *The basic problem that the KIP tries to solve is > > that kafka-configs.sh (which in turn uses the ConfigCommand class) uses a > > direct zookeeper connection. This is not desirable as getting around the > > broker opens up security issues and prevents the tool from being used in > > deployments where only the brokers are exposed to clients. Also a somewhat > > smaller motivation is to rewrite the tool in java as part of the tools > > component so we can get rid of requiring the core module on the classpath > > for the kafka-configs tool. > > *Solution:* > > - I've designed new 2 protocols: DescribeQuotas and AlterQuotas. > > - Also redesigned the output format of the command line tool so it provides > > a nicer result. > > - kafka-configs.[sh/bat] will use a new java based ConfigCommand that is > > placed in tools. > > > > > > I'd be happy to receive any votes or feedback on this. > > > > Regards, > > Viktor > >
