Guozhang, renaming the class is an internal change and I think it's not required to cover it in the KIP.
+1 (binding) -Matthias On 3/9/18 1:26 PM, Guozhang Wang wrote: > Hi John, > > You mentioned you are going to do the renaming for the existing class > to InternalMockProcessorContext > but that seems not reflected on the KIP wiki, could you add that in the > proposed changes section? > > Other than that, I'm +1 on the KIP. > > Thanks! > > Guozhang > > On Fri, Mar 9, 2018 at 12:39 PM, Ted Yu <yuzhih...@gmail.com> wrote: > >> +1 >> -------- Original message --------From: Bill Bejeck <bbej...@gmail.com> >> Date: 3/9/18 12:29 PM (GMT-08:00) To: dev@kafka.apache.org Subject: Re: >> [VOTE] KIP-267: Add Processor Unit Test Support to Kafka Streams Test Utils >> Thanks for the KIP. >> >> +1 >> >> -Bill >> >> On Fri, Mar 9, 2018 at 3:16 PM, John Roesler <j...@confluent.io> wrote: >> >>> Hello all, >>> >>> I'd like to start voting on KIP-267, to introduce a MockProcessorContent >>> enabling Processor, Transformer, and ValueTransformer authors to >> unit-test >>> their components. >>> >>> https://cwiki.apache.org/confluence/display/KAFKA/KIP- >>> 267%3A+Add+Processor+Unit+Test+Support+to+Kafka+Streams+ >>> Test+Utils?src=jira >>> >>> Thanks, >>> -John >>> >> > > >
signature.asc
Description: OpenPGP digital signature
