Hi, Colin, Thanks for the KIP. Looks good to me overall. Just a couple of more comments.
1. As I mentioned earlier, it might be useful to add some metrics for monitoring the usage of the session cache. For example, it would be useful to know how many slots are being used (or unused), # of total partitions in the cached slots (to understand space), the eviction rate (to see if there is any churn), etc. 2. Using max_bytes to 0 represent the removal of a partition seems unintuitive. Perhaps it's better to either add a flag per partition or add a removed partition list. Jun On Thu, Jan 18, 2018 at 6:15 PM, Colin McCabe <cmcc...@apache.org> wrote: > Hi all, > > I updated the KIP. There is also an implementation of this KIP here: > https://github.com/apache/kafka/pull/4418 > > The updated implementation simplifies a few things, and adds the ability > to incrementally add or remove individual partitions in an incremental > fetch request. > > best, > Colin > > > On Tue, Dec 19, 2017, at 19:28, Colin McCabe wrote: > > Hi all, > > > > I'd like to start the vote on KIP-227: Incremental Fetch Requests. > > > > The KIP is here: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 227%3A+Introduce+Incremental+FetchRequests+to+Increase+ > Partition+Scalability > > > > and discussion thread earlier: > > https://www.mail-archive.com/dev@kafka.apache.org/msg83115.html > > > > thanks, > > Colin >
