There are 3 binding votes and 2 nonbinding votes in favor of KIP-239. Binding: Guozhang Wang Damian Guy Ewen Cheslack-Postava
Nonbinding: Matthias J. Sax Bill Bejeck This would close this voting thread. On Tue, Jan 2, 2018 at 10:24 PM, Matthias J. Sax <matth...@confluent.io> wrote: > @Richard: you can close this vote thread with a summary as usual and > update the KIP wiki page accordingly. > > > -Matthias > > On 1/2/18 9:57 PM, Richard Yu wrote: > > A subsequent PR has already been created: > > https://github.com/apache/kafka/pull/4340/ > > It should be seen on the JIRA. > > > > > > > > On Tue, Jan 2, 2018 at 9:51 PM, Ewen Cheslack-Postava <e...@confluent.io > > > > wrote: > > > >> Oh, the KIP passes w/ the required votes. My comment was just on > >> implementation details. I will leave comments about that up to the > >> subsequent PR and to the Kafka Streams folks that are much better suited > >> than me to comment on them :) > >> > >> -Ewen > >> > >> On Tue, Jan 2, 2018 at 9:28 PM, Richard Yu <yohan.richard...@gmail.com> > >> wrote: > >> > >>> After investigation, I have found that the > >>> InternalStreamsBuilder#globalTable method is the only instance where > the > >>> constructor for GlobalKTableImpl is called. > >>> The KTableValueGetterSupplier parameter used in this particular > >> constructor > >>> is an instance of KTableSourceValueGetterSupplier. Hence, your > >> requirement > >>> is satisfied. > >>> > >>> Since this is the vote thread, if you have further comments, please > >> comment > >>> on the pull request. > >>> > >>> On Tue, Jan 2, 2018 at 6:38 PM, Ewen Cheslack-Postava < > e...@confluent.io > >>> > >>> wrote: > >>> > >>>> +1 binding > >>>> > >>>> The idea seems reasonable. Looking at it implementation-wise, seems > >> there > >>>> is a bit of awkwardness because GlobalKTableImpl uses a > >>>> KTableValueGetterSupplier which seems to possibly have multiple > stores, > >>> but > >>>> maybe using the more specific KTableSourceValueGetterSupplier > >>>> implementation instead can resolve that. > >>>> > >>>> -Ewen > >>>> > >>>> On Mon, Jan 1, 2018 at 6:22 PM, Ted Yu <yuzhih...@gmail.com> wrote: > >>>> > >>>>> Gentle reminder: one more binding vote is needed for the KIP to pass. > >>>>> > >>>>> Cheers > >>>>> > >>>>> On Thu, Dec 21, 2017 at 4:13 AM, Damian Guy <damian....@gmail.com> > >>>> wrote: > >>>>> > >>>>>> +1 > >>>>>> > >>>>>> On Wed, 20 Dec 2017 at 21:09 Ted Yu <yuzhih...@gmail.com> wrote: > >>>>>> > >>>>>>> Ping for more (binding) votes. > >>>>>>> > >>>>>>> The pull request is ready. > >>>>>>> > >>>>>>> On Fri, Dec 15, 2017 at 12:57 PM, Guozhang Wang < > >>> wangg...@gmail.com> > >>>>>>> wrote: > >>>>>>> > >>>>>>>> +1 (binding), thanks! > >>>>>>>> > >>>>>>>> On Fri, Dec 15, 2017 at 11:56 AM, Ted Yu <yuzhih...@gmail.com> > >>>>> wrote: > >>>>>>>> > >>>>>>>>> Hi, > >>>>>>>>> Here is the discussion thread: > >>>>>>>>> > >>>>>>>>> http://search-hadoop.com/m/Kafka/uyzND12QnH514pPO9?subj= > >>>>>>>>> Re+DISCUSS+KIP+239+Add+queryableStoreName+to+GlobalKTable > >>>>>>>>> > >>>>>>>>> Please vote on this KIP. > >>>>>>>>> > >>>>>>>>> Thanks > >>>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> -- > >>>>>>>> -- Guozhang > >>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > > > >
