GitHub user kdrakon opened a pull request:

    https://github.com/apache/kafka/pull/4346

    appends Materialized#with to include the ability to specify the store name 
as well as the serdes

    `Materialized#with` doesn't allow you to specify both a store name and the 
key/value serdes. If you specify the name using `#as`, then the serdes are 
implied/inferred to be for `Serde<Object>` and it becomes ugly to use 
`#withKeySerde`, `#withValueSerde`, etc. This overload of `Materialized#with` 
allows both the store name *and* the specific Serdes desired to be specified in 
one go.
    
    I've updated `MaterializedTest` with the expected new behaviour as well as 
the old behaviour (i.e. `null` store name when not specified).
    
    ### Committer Checklist (excluded from commit message)
    - [x] Verify design and implementation 
    - [x] Verify test coverage and CI build status
    - [x] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kdrakon/kafka 
kdrakon/adding-storename-to-Materialized#with

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4346.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4346
    
----
commit a5394b1f92ee2cc6542d38e3e31834bc30917eca
Author: Sean Policarpio <sean.policarpio@...>
Date:   2017-12-20T12:12:01Z

    appends Materialized#with to include the ability to specify the store name 
as well as the serdes

----


---

Reply via email to