I've removed the option to pass a null reassignments argument to AdminClient.describeReassignments(), because to support this would require passing the topic and partition of each reassignment in the response, for what might be many partitions. It just seems like unnecessary bloat.
AdminClient.listPartitions() already provides for passing a null collection of partitions to discover all the reassignments, so overall there is no loss of functionality. I'm happy to add it back if people really think it's necessary. On 18 December 2017 at 10:49, Tom Bentley <t.j.bent...@gmail.com> wrote: > Hi Ted, > > For class Reassignment, it seems you forgot to include set of brokers. > > > I omitted a set of brokers intentionally, because the Reassignment is a an > immutable reference to a (mutable) reassignment (in ZooKeeper). See KIP-236 > to understand the background. > > I've fixed the other two issues, thanks for noticing them. > > Cheers, > > Tom > > On 15 December 2017 at 18:53, Ted Yu <yuzhih...@gmail.com> wrote: > >> Please create corresponding JIRA. >> >> For class Reassignment, it seems you forgot to include set of brokers. >> >> For class DescribeReassignmentsResult: >> public KafkaFuture<Reassignment> reassignments(); >> the return value should be a Collection. >> >> >> On Fri, Dec 15, 2017 at 10:16 AM, Tom Bentley <t.j.bent...@gmail.com> >> wrote: >> >> > Hi, >> > >> > KIP-236 lays the foundations for AdminClient APIs to do with partition >> > reassignment. I'd now like to start discussing KIP-240, which adds APIs >> to >> > the AdminClient to list and describe the current reassignments. >> > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-240% >> 3A+AdminClient. >> > listReassignments+AdminClient.describeReassignments >> > >> > Aside: I have fairly developed ideas for the API for starting a >> > reassignment, but I intend to put that in a third KIP. >> > >> > Cheers, >> > >> > Tom >> > >> > >
