Jun, Thanks for the feedback. Some things need to make sure. Currently, these new-added metrics follow the exact naming convention with those 'lag' counterparts, as shown below:
[cid:fcb78ea1-d9ac-48f4-a4ac-4fca7208af11] Consumer-level metric: records-lag-max ==> records-lead-min Partition-level metrics: <topic>-<partitionId>.records-lag ==> <topic>-<partitionId>.records-lead <topic>-<partitionId>.records-lag-max ==> <topic>-<partitionId>.records-lead-min <topic>-<partitionId>.records-lag-avg ==> <topic>-<partitionId>.records-lead-avg Correct me if I am wrong, but what you mentioned `records-lead-avg and records-lead-min don't need the partition prefix since they are aggregates across all partitions` seemed to break the naming rule above. Do we still have to keep the same rule with the "lag" metrics? huxihx ________________________________ 发件人: Jun Rao <j...@confluent.io> 发送时间: 2017年11月14日 1:48 收件人: dev@kafka.apache.org 主题: Re: [DISCUSS]KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer Hi, Hu, Thanks for the KIP. Looks good overall. Could you document the mbean name for the new metrics? We probably want the name to be consistent with records-max-lag as described in http://kafka.apache.org/documentation/#monitoring. Also, it seems that [http://apache-kafka.org/images/apache-kafka.png]<http://kafka.apache.org/documentation/#monitoring> Apache Kafka<http://kafka.apache.org/documentation/#monitoring> kafka.apache.org 1.2 Use Cases. Here is a description of a few of the popular use cases for Apache Kafka®. For an overview of a number of these areas in action, see this blog post. records-lead-avg and records-lead-min don't need the partition prefix since they are aggregates across all partitions. For records-lead, it seems that it's better to add the topic partition as a tag, instead of as a prefix in the metric name. Jun On Thu, Nov 9, 2017 at 1:03 AM, Hu Xi <huxi...@hotmail.com> wrote: > Hi all, > > > As per Jun Rao's suggestion, I opened up the KIP-223(https://cwiki.apache. > org/confluence/display/KAFKA/KIP-223+-+Add+per-topic+min+ > lead+and+per-partition+lead+metrics+to+KafkaConsumer) concerning adding > new kinds of lag metrics for KafkaConsumer. Be free to leave your comments > here. Thanks in advance. > >
